Timeshift broken on stream restart, issue #4096 #928
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a subscription gets overridden (and possible in other "stop" cases too), the timeshift reader and writer threads gets closed. The subscription stays running in idle state, but when it resumes (free tuner for example), timeshift won't be restarted.
This causes 2 problems:
Related to:
https://tvheadend.org/issues/4096#change-20566
@perexg I'm not sure if this is a "correct" fix, please give your opinion