CI/CD: Add ccache to native builds #1670
Conversation
![prplex[bot]](https://avatars.githubusercontent.com/in/353986?s=60&v=4){kind=small}
.github/workflows/build-ci.yml
Outdated
| @@ -189,6 +189,11 @@ jobs: | |||
| if: startsWith(matrix.container, 'i386') || matrix.container == 'debian:stretch' | |||
| - name: Workaround safe directory | |||
| run: git config --global --add safe.directory /__w/tvheadend/tvheadend | |||
| - name: ccache | |||
| uses: hendrikmuhs/[email protected] | |||
There was a problem hiding this comment.
I can see that ccache is being used to improve build times. This is a good addition, but the 'save' option is set to 'false' here. If we don't save the ccache after a build, the cache won't persist after this job, thus missing the very purpose of ccache. Please consider setting 'save: true' to leverage ccache effectively.
.github/workflows/build-ci.yml
Outdated
| @@ -221,6 +226,11 @@ | |||
| - uses: actions/checkout@v1 | |||
| - name: Workaround safe directory | |||
| run: git config --global --add safe.directory /__w/tvheadend/tvheadend | |||
| - name: ccache | |||
| uses: hendrikmuhs/[email protected] | |||
There was a problem hiding this comment.
Same as above, the 'save' option in ccache is set to 'false'. Consider setting it to 'true' for better utilization of ccache.
| - name: ccache | ||
| uses: hendrikmuhs/[email protected] | ||
| with: | ||
| key: ${{ matrix.container }} | ||
| - name: build | ||
| run: AUTOBUILD_CONFIGURE_EXTRA=--enable-ccache\ --enable-ffmpeg_static\ --enable-hdhomerun_static\ --python=python3 ./Autobuild.sh ${{ (startsWith(matrix.container, 'i386') && '-a i386') || '' }} |
There was a problem hiding this comment.
For better maintainability, consider moving such complex commands into a script file instead of having them inline.
Be aware that enabling ccache in the project might not result in build speed improvements if the nature of the project results in a low ccache hit rate.
|
No description provided.