ci: update upload-artifact@v3 to upload-artifact@v4

[chewitt]

This should silence the following warnings during workflow runs:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

[prplex]

Review completed. Posted 4 comments.

[Flole998]

IIRC I saw these (or similar) issues when initially setting up GH actions, so I went with the older version. It needs to be addressed at some point though.

[chewitt]

One of the v3 > v4 differences is not allowing the same file to be uploaded more than once, so I think we might have some name collisions taking place. If yes, the solution will be to tweak the artefact naming.

[Flole998]

If it's the name field, then yes, we have a huge deb and a not so huge rpm zip artifact. That should probably be improved/changed.

[Flole998]

IIRC I saw these (or similar) issues when initially setting up GH actions, so I went with the older version. It needs to be addressed at some point though.

I just looked it up again: That was for the checkout action, not for upload artifact.

[chewitt]

I'll investigate in the week. I still have relatives in-town so not much time for reading GitHub docs at the moment :)

[Flole998]

I'd guess all that's needed is adding a variable to the name for the architecture. Just a guess though and the docs should clear that up. No need to rush though.

[sonarcloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[Flole998]

You'll probably need to add the architecture to it somehow, otherwise i386 and x64 are conflicting again.