Clean transcoding when htsp based transcoding is used #1391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@perexg There was an issue when HTSP clients like kodi used a transcoding profile (especially nvidia based profiles) so the transcoder was never cleaned up which caused more and more GPU memory to be used. This fixes it for me but I have absolutely no idea if this is a proper fix or if
run
should evaluate to true in this case and the cleanup code from above should be used instead. There is no profile sharer thread started in this case if I saw that correctly, so it should be correct that run evaluates to 0 but it could be that a profile sharer thread should be started in this case. Really not sure about this and I would appreciate if you could look over this and approve this or reject this is this is not a proper fix (and I believe that this is not a proper fix).