Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart 3 support & Fix icon white line and add shadow for dark theme #69

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Eimji
Copy link

@Eimji Eimji commented Apr 26, 2022

Hello,

Thanks for your great work.

I would like to submit two fixes with icons in the navigation bar:

  • look at an icon carefully, and you will observe there is a white line (at the top edge of the navigation bar);
  • add shadow for selected icon for dark themes

Thanks.

@Eimji Eimji changed the title Fix icon white line and add shadow for dark theme Dart 3 support & Fix icon white line and add shadow for dark theme Oct 1, 2023
@Eimji
Copy link
Author

Eimji commented Oct 1, 2023

Hello,
Could you merge this PR please?

Changelog:

  • Update dependencies( & support for Dart 3)
  • Migrate the example to to the V2 embedding
  • Fix UI issues (cf my previous message)

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant