Create delete topic error structure #1646
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfoltz
reviewed
Jan 7, 2024
src/admin/index.js
Outdated
| throw e | ||
| } | ||
|
|
||
| if ('NOT_CONTROLLER'.includes(e.type)) { |
There was a problem hiding this comment.
Same here, this should be e.type === 'NOT_CONTROLLER'.
There was a problem hiding this comment.
@gfoltz you are totally right. I have changed how error type is checked.
Thank you.
src/admin/index.js
Outdated
| logger.warn('Could not delete topics', { error: e.message, retryCount, retryTime }) | ||
| if ( | ||
| e.name === 'KafkaJSAggregateError' && | ||
| e.errors.some(error => error.type.includes('UNKNOWN_TOPIC_OR_PARTITION')) |
There was a problem hiding this comment.
This should be error => error.type === 'UNKNOWN_TOPIC_OR_PARTITION'. The use of includes in the original code was on an Array. But here you're using it on a string, which works but I think only accidentally, and I'm pretty sure is not what you intend.
There was a problem hiding this comment.
This one is also changed.
Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to #957 and #129
Add information which topics cannot be deleted when user tries to delete topics.