fix: refreshMetadata should retry if topic does not exist and allowAu… #1558
Conversation
…toTopicCreation is set
|
will this be merged soon? |
|
When will this be fixed and merged? @Nevon |
|
Any idea when this will be merged? |
|
This PR looks promising in fixing part (or all of) of #815 Basically ever since Kafka moved from Zookeeper to KRaft there seems to have been a breaking change in auto-topic creation on subscription. It looks like with zookeeper back in the day you could subscribe to a non-existent topic just fine, it would be created behind the scenes and the subscription succeeds. now with KRaft subscribing to a non-existent topic throws With this PR the (correct) action of retrying the subscription after waiting a bit seems to be used. As this PR does not have any reviewers maybe you could have a look @tulios ? |
|
The PR would also close #1563 |
|
This looks good to go to me. |
This PR is a temporary workaround for tulios/kafkajs#1558 until it gets fixed. If topic autocreation is on and you try to subscribe to a nonexistent topic, KafkaJS should retry until the topic is created. However, curently KafkaJS does not retry, so Transact will instead.
…toTopicCreation is set
fix: #815
Not sure why it happens but it happens randomly. Seems like a race condition when 2 client try to create the same topic at the same time. This fix is tested and working