Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements current Vue object creation for Vue object in Index.html #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wscrimsher3
Copy link

Hi,
first real pull request for an open source project.
Give me a heads up if anything seems wrong

@ttu
Copy link
Owner

ttu commented Mar 9, 2023

Hi and thanks for trying to fix the issue 👍

I still get a blank page. I think the issue might be that Vue version from <script src="https://unpkg.com/vue"></script> is v3 and this was originally written when latest Vue version was 2.x.

If you switch
<script src="https://unpkg.com/vue"></script>
to
<script src="https://unpkg.com/[email protected]/dist/vue.js"></script>
you will get the version is master working and should see this:
image

You can either do that change in this PR or try to change the implementation to V3. This has a pretty similar example with Vue V3, so you can take example from there if you wish: https://github.com/ttu/multi-camera-system/blob/main/src/templates/index.html

You can also make these changes in separate PRs, so in e.g. this one pin the version from script to v2 and then index.html will be again working and then in the another PR migrate the code to Vue V3.

Thanks again and let me know if you have more questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants