Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Enforcing stdout raw output for confirmation inputs #2693

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

gvicentin
Copy link
Member

@gvicentin gvicentin commented Apr 30, 2024

Using the tsuru-client sometimes we can't see the confirmation input before entering the answer.

How to reproduce:

# normal behaviour
$ tsuru app remove -a gvicentin-static
Are you sure you want to remove app "gvicentin-static"? (y/n) n
Abort.

# bug happens not only here but with some other commands too
$ tsuru service instance remove rpaasv2-be gvicentin-be
n
Are you sure you want to remove the instance "gvicentin-be"? (y/n) Abort.

Since every confirmation input should not use pagination, we can call the RawOutput function to fix this weird behaviour.

@gvicentin gvicentin changed the title bugfix: Enforcing std raw output for confirmation inputs bugfix: Enforcing stdout raw output for confirmation inputs Apr 30, 2024
@gvicentin gvicentin requested a review from wpjunior April 30, 2024 16:55
@wpjunior wpjunior merged commit 10560a3 into tsuru:main Apr 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants