Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactor graph_connect.go for better readability #69

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

akokhanovskyi
Copy link
Contributor

@akokhanovskyi akokhanovskyi commented Nov 2, 2020

This is WIP, please do not merge yet; comments are welcome!

@codecov-io
Copy link

codecov-io commented Nov 2, 2020

Codecov Report

Merging #69 into master will decrease coverage by 1.85%.
The diff coverage is 80.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   89.47%   87.61%   -1.86%     
==========================================
  Files           6        7       +1     
  Lines         304      323      +19     
==========================================
+ Hits          272      283      +11     
- Misses         17       26       +9     
+ Partials       15       14       -1     
Impacted Files Coverage Δ
graph_connect.go 89.85% <78.94%> (-1.45%) ⬇️
address.go 80.95% <80.95%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35d1d63...f8a9e16. Read the comment docs.


if port.Cap() <= key {
port.SetCap(2 * key)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is guaranteed to panic. To "extend" the underlying array, you have to reallocate the slice and copy the data.

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2021

Codecov Report

Merging #69 (265c5fa) into master (b48b2ee) will decrease coverage by 1.13%.
The diff coverage is 84.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   89.43%   88.30%   -1.14%     
==========================================
  Files           6        7       +1     
  Lines         303      342      +39     
==========================================
+ Hits          271      302      +31     
- Misses         17       22       +5     
- Partials       15       18       +3     
Impacted Files Coverage Δ
factory.go 100.00% <ø> (ø)
graph_iip.go 75.00% <33.33%> (-8.34%) ⬇️
graph_ports.go 75.75% <50.00%> (-9.43%) ⬇️
graph.go 82.97% <75.00%> (-0.70%) ⬇️
graph_connect.go 89.62% <77.50%> (-1.68%) ⬇️
address.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48b2ee...265c5fa. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants