adds missing permissions for encrypted sns topics #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rpdelaney ! Thanks for fixing the docs 🙏 is anything else missing so we can have this merged? Please let me know. Thank you!! |
|
hey @rpdelaney! Anything missing to merge this? let me know please. Thank you 🙇 |
|
I'm sorry, but I am moving on from Truss. I did create a card on our internal issue tracker, so hopefully someone will act on this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
This pull request adds missing permissions on the role associated with the AWS config to be able to use encrypted SNS topics. When an SNS topic is encrypted, additional permissions need to be added to the role or service that is publishing the messages to SNS.
The documentation on AWS config is not clear about this but you can find other examples on AWS for other services that explicitly say the required permissions to be able to publish messages on encrypted SNS topics. For example:
This pull request also adds an example with an encrypted SNS topic.