build: improve DangerJS checks #2331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gidjin
force-pushed
the
gidjin/fix-dangerjs-checks
branch
from
042f12f
to
ad23e9a
Compare
gidjin
force-pushed
the
gidjin/fix-dangerjs-checks
branch
from
472c975
to
e61bb5b
Compare
gidjin
force-pushed
the
gidjin/fix-dangerjs-checks
branch
from
e61bb5b
to
3a3c8f5
Compare
|
@gidjin anything I can verify here? I see danger has been passing on PRs, including this one. Changes look good to me as well. |
|
I'm also noticing that danger currently fails on main because it's looking for things that are only defined in PR context |
|
@all-contributors please add @gidjin for maintenance |
|
I've put up a pull request to add @gidjin! 🎉 |
|
@gidjin what's still needed to merge this? |
I think I was trying to see how / why Danger didn't run for 3rd party PRs. Since then this isn't blocking PRs and has been running on our own PR so I'm going to close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improvements to the DangerJS checks
How To Test
Once #2330 is merged you can trigger the build checks workflow to see danger execute on this branch.