Remove if len(match) != 2
check in detectors
#2746
Open
+109
−2,967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I believe the intention behind this code was to make sure that a given pattern matched, but it doesn't actually do this. A while ago, I explained in a PR comment how the
if len(match) != 2
check doesn't necessarily do what it appears to, and how it can actually silently break detectors.In short,
FindAllStringSubmatch
only returns results that match the given pattern. The number of match groups in a specific match is static, meaning that the pattern(fo.)bar(.?)
will always have 3 groups even if the group afterbar
is empty. If the number of match groups in a pattern is changed and the if statement isn't, it will cause matches to be silently discarded.https://go.dev/play/p/TXYh1bQItaO
Checklist:
make test-community
)?make lint
this requires golangci-lint)?