NAS-129123 / 24.10 / Expand error recovery in AD health checks #13781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
mgrimesix
reviewed
May 24, 2024
anodos325
force-pushed
the
NAS-129123
branch
2 times, most recently
from
f9271ce
to
e1aa30c
Compare
bmeagherix
approved these changes
May 28, 2024
mgrimesix
approved these changes
May 28, 2024
This primarily adds two new features to our AD health checks * Check whether the secrets.tdb file exists and has a valid machine account password. If it's missing, then try to restore from backup. * Check whether we have a stored kerberos keytab for the AD domain. If it's missing, reconstruct it from our machine account password in the secrets.tdb file.
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This primarily adds two new features to our AD health checks
Check whether the secrets.tdb file exists and has a valid machine account password. If it's missing, then try to restore from backup.
Check whether we have a stored kerberos keytab for the AD domain. If it's missing, reconstruct it from our machine account password in the secrets.tdb file.
This commit also refactors the kerberos plugin to move many methods into general-purpose krb5 utils that can be tested more easily in isolation.