NAS-129169 / 24.10 / log ALL THE THINGS #13778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonicaj
approved these changes
May 22, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've discovered, while investigating an unrelated problem, that the HA failover process was "hung" waiting on non-ZFS related tasks (at least from the information that I could coerce out of the system). This happens rarely enough that unless you're prepared, it's very hard to gather the collateral quickly enough before the failover process has finished.
This is not a solution for that problem, but this makes it so that the failover process is extremely verbose around all operations. This will at least give us an idea of an endpoint that could be "blocking" or causing a "longer than expected" amount of time to complete.
While I was here, I renamed the
start_apps_vmsmethod. We do not support VMs on HA at the moment so there is no reason to keep that logic here. Rename it accordingly.