Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): lazy routers #5489

Draft
wants to merge 20 commits into
base: next
Choose a base branch
from
Draft

feat(server): lazy routers #5489

wants to merge 20 commits into from
+445 −74

Conversation

KATT
Copy link
Member

@KATT KATT commented Feb 16, 2024 •
edited

Closes #4129

🎯 Changes

You can test this by installing @trpc/server@tmp / @trpc/client@tmp / .. etc

✅ Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

@KATT KATT added the 🚧 wip work in progress label Feb 16, 2024
@vercel Vercel
Copy link

vercel bot commented Feb 16, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-prisma-starter ❌ Failed (Inspect) Mar 22, 2024 0:01am
og-image ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 0:01am
trpc-next-app-dir ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 0:01am
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 0:01am

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 16, 2024 •
edited

Diagnostics Comparison

Numbers

Metric PR next
Files 779 779 (➖ 0)
Lines of Library 40,640 40,640 (➖ 0)
Lines of Definitions 117,246 117,236 (🔺 10)
Lines of TypeScript 4,967 4,967 (➖ 0)
Lines of JavaScript 0 0 (➖ 0)
Lines of JSON 0 0 (➖ 0)
Lines of Other 0 0 (➖ 0)
Identifiers 173,968 173,930 (🔺 38)
Symbols 108,105 108,081 (🔺 24)
Types 89 89 (➖ 0)
Instantiations 0 0 (➖ 0)
Memory used 167,929 171,469 (🔽🟢 -3,540)
Assignability cache size 0 0 (➖ 0)
Identity cache size 0 0 (➖ 0)
Subtype cache size 0 0 (➖ 0)
Strict subtype cache size 0 0 (➖ 0)

Timings and averages

Metric PR next
max (s) 4.368 4.592 (🔽🟢 -0.22)
min (s) 4.368 4.592 (🔽🟢 -0.22)
avg (s) 4.368 4.592 (🔽🟢 -0.22)
median (s) 4.368 4.592 (🔽🟢 -0.22)
length 1 1 (➖ 0)
unstable timings

Unstable

Timings are not reliable in here

Metric PR next
I/O Read time 0.05 0.04 (🔺 0.01)
Parse time 0.7 0.75 (🔽🟢 -0.05)
ResolveTypeReference time 0.03 0.03 (➖ 0)
ResolveModule time 0.12 0.12 (➖ 0)
ResolveLibrary time 0.02 0.02 (➖ 0)
Program time 1.05 1.09 (🔽🟢 -0.04)
Bind time 0.41 0.41 (➖ 0)
Total time 1.46 1.5 (🔽🟢 -0.04)

KATT
KATT commented Feb 16, 2024
View reviewed changes
examples/lazy-load/src/server/index.ts
Comment on lines +5 to +13
import { lazy } from '@trpc/server/unstable-core-do-not-import';
import { router } from './trpc.js';

const user = lazy(() =>
import('./routers/user.js').then((m) => {
console.log('💤 lazy loaded user router');
return m.userRouter;
}),
);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @zomars here's an example on how to use it

@MathiasGruber
Copy link

I've started my migration, may take a bit to get through, but I'll give an update once I'm back to testing the lazy loading

@MathiasGruber
Copy link

Managed to bump tRPC to 11.0.0-next-beta.308 and got everything to work. Then swapped back to tmp, and now everything is working perfectly when running locally. When trying to build, however, I get errors on all pages complaining about unsafe assignment of any:
image

My current code changes from 308 to the tmp branch:
https://github.com/MathiasGruber/TheNinjaRPG/pull/72/files

@jonathanwilke
Copy link

Really excited to try this for supastarter. Is this supposed to work on edge functions too?

@zomars zomars mentioned this pull request Mar 14, 2024
Draft
1 task
@MathiasGruber
Copy link

MathiasGruber commented Mar 21, 2024 •
edited

Big apologies @KATT , I tried this again after rebasing on my main branch, and it seems to have been something on my end that was broken. It's working now, no issues from my entire application. Good job! 🚀🎉

@KATT
Copy link
Member Author

KATT commented Mar 21, 2024

Does it make a difference for the cold starts?

@KATT
Merge remote-tracking branch 'origin/next' into issues/4129-lazy-routers
cf8d1ab 
# Conflicts:
#	.github/workflows/release-tmp.yml
#	pnpm-lock.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🚧 wip work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Lazy load routers
3 participants
@KATT @MathiasGruber @jonathanwilke