Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade prettier to v3 #5346

Open
wants to merge 20 commits into
base: next
Choose a base branch
from
Open

chore: upgrade prettier to v3 #5346

wants to merge 20 commits into from

Conversation

ixahmedxi
Copy link
Contributor

No description provided.

@ixahmedxi ixahmedxi requested a review from a team as a code owner January 16, 2024 21:12
Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-prisma-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 1:54am
og-image ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 1:54am
trpc-next-app-dir ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 1:54am
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 1:54am

Copy link

github-actions bot commented Jan 16, 2024

Diagnostics Comparison

Numbers

Metric PR next
Files 774 775 (🔽🟢 -1)
Lines of Library 40,241 40,241 (➖ 0)
Lines of Definitions 118,804 119,736 (🔽🟢 -932)
Lines of TypeScript 4,867 4,867 (➖ 0)
Lines of JavaScript 0 0 (➖ 0)
Lines of JSON 0 0 (➖ 0)
Lines of Other 0 0 (➖ 0)
Identifiers 174,436 175,852 (🔽🟢 -1,416)
Symbols 108,573 109,497 (🔽🟢 -924)
Types 89 89 (➖ 0)
Instantiations 0 0 (➖ 0)
Memory used 169,040 172,612 (🔽🟢 -3,572)
Assignability cache size 0 0 (➖ 0)
Identity cache size 0 0 (➖ 0)
Subtype cache size 0 0 (➖ 0)
Strict subtype cache size 0 0 (➖ 0)

Timings and averages

Metric PR next
max (s) 4.759 4.728 (🔺 0.03)
min (s) 4.759 4.728 (🔺 0.03)
avg (s) 4.759 4.728 (🔺 0.03)
median (s) 4.759 4.728 (🔺 0.03)
length 1 1 (➖ 0)
unstable timings

Unstable

Timings are not reliable in here

Metric PR next
I/O Read time 0.04 0.04 (➖ 0)
Parse time 0.77 0.74 (🔺 0.03)
ResolveTypeReference time 0.03 0.03 (➖ 0)
ResolveModule time 0.11 0.11 (➖ 0)
ResolveLibrary time 0.02 0.02 (➖ 0)
Program time 1.08 1.08 (➖ 0)
Bind time 0.47 0.44 (🔺 0.03)
Total time 1.56 1.52 (🔺 0.04)

juliusmarminge
juliusmarminge previously approved these changes Jan 17, 2024
"next": "^14.0.1",
"next-auth": "^4.22.1",
"npm-run-all": "^4.1.5",
"oauth": "^0.10.0",
"postcss": "^8.4.14",
"prettier": "^2.8.8",
"prettier": "npm:prettier@^2.8.8",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pinned this to prettier 2 -- @ixahmedxi see if we can just remove it here instead somehow. Idk how/why prettier is included in docusaurus' build

Copy link
Member

@KATT KATT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs updating now that @trpc/core has been removed

Might be easiest to cherry-pick the package.json-changes to a new PR and let the autofixer do its thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants