Added implementatin for kadane's algorithm #1031
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundaram123krishnan
changed the title
| */ | ||
|
|
||
| export default function kadane() { | ||
| let current_sum = array[0]; |
There was a problem hiding this comment.
Thanks for pointing out , i forgot to add parameter to function.
janydoe
suggested changes
Jun 22, 2023
| * Simplest Kadane's algorithm implementation. | ||
| * | ||
| * @param {*[]} array | ||
| * @return {number[]} |
There was a problem hiding this comment.
Suggested change
| * @return {number[]} | |
| * @return {number} |
| /** | ||
| * Simplest Kadane's algorithm implementation. | ||
| * | ||
| * @param {*[]} array |
There was a problem hiding this comment.
Suggested change
| * @param {*[]} array | |
| * @param {number[]} array |
|
|
||
| // This algorithm works for both positive and negative values of the array | ||
|
|
||
| let current_sum = array[0]; |
There was a problem hiding this comment.
Suggested change
| let current_sum = array[0]; | |
| let current_sum = array[0] ?? 0; |
| // This algorithm works for both positive and negative values of the array | ||
|
|
||
| let current_sum = array[0]; | ||
| let maximum_subarray_sum = array[0]; |
There was a problem hiding this comment.
Suggested change
| let maximum_subarray_sum = array[0]; | |
| let maximum_subarray_sum = array[0] ?? -Infinity; |
or
Suggested change
| let maximum_subarray_sum = array[0]; | |
| let maximum_subarray_sum = array[0] ?? - Math.pow(2, 53) - 1; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change attempts to resolve issue #1030.
Only included the implementation of the algorithm, let me know whether i should further continue to contribute or not.
Signed-off-by : Sundaram krishnan [email protected]