fix(rust): access CARGO_MANIFEST_DIR at runtime in build script
#3352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `CARGO_MANIFEST_DIR` environment variable should be accessed by `build.rs` at run time rather than compile time. This was for example causing issues when importing `tree-sitter` via [`rules_rust`](https://github.com/bazelbuild/rules_rust) in bazel, where compilation and running happen in separate environments.
hendrikvanantwerpen
approved these changes
May 13, 2024
dcreager
approved these changes
May 13, 2024
There was a problem hiding this comment.
This looks right to me, too, but I haven't touched this part of the code in awhile. @maxbrunsfeld and/or @amaanq does this look 👍 to you?
|
yeah this is great! thanks for the reminder @dcreager |
amaanq
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CARGO_MANIFEST_DIRenvironment variable should be accessed bybuild.rsat run time rather than compile time. This was for example causing issues when importingtree-sitterviarules_rustin bazel, where compilation and running happen in separate environments.Closes #3353