Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link to tree-sitter-wit #3348

Closed

Conversation

Michael-F-Bryan
Copy link

No description provided.

@sogaiu
Copy link

sogaiu commented May 7, 2024

Curious how this differs from the other two listed here (though I guess one of those two looks a little old).

@Michael-F-Bryan
Copy link
Author

The parser from @hh9527 seems to be for an older WIT syntax from before the concepts of "packages" and "worlds" were introduced.

It looks like both my parser and @liamwh are essentially equivalent, although I believe my version has more testing and is currently used by the Language Server in that repo.

@liamwh
Copy link

liamwh commented May 7, 2024

I agree that the parser from @hh9527 is out of date and should not be used.

I would propose adding my tree-sitter-wit to this list instead as it is used daily "in-production" (developers' Neovim instances) and is compliant with and installable via nvim-treesitter. My version is actively maintained and I intend to continue to maintain it as the WIT spec evolves, and consequently hope that no more tree-sitter-wit libraries appear. @Michael-F-Bryan if you feel you have any improvements I would recommend making a PR to my repo, though I'm not aware of any at this time (besides maybe publishing the NPM/Crates.io/PyPI packages).

I think it's super cool that you're making a WIT LSP though and wish you the best success with it @Michael-F-Bryan!

@Michael-F-Bryan
Copy link
Author

@liamwh I'm happy to link to your parser in preference to mine. It's one less thing for me to maintain and worry about, and if you are using it in production then that's a pretty good guarantee it'll stay up to date 🙂

If it's alright with you, I might also make a PR to your repo to add my test cases and a couple of modifications I've made to the Rust bindings (mostly tests).

@sogaiu, I'll close this issue in favour of #3349.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants