Support request-level getMessageById() and upsertMessage() opts #537
+14
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxmiron
commented
Apr 15, 2023
| @@ -87,7 +89,7 @@ export class ChatGPTError extends Error { | |||
| } | |||
|
|
|||
| /** Returns a chat message from a store by it's ID (or null if not found). */ | |||
| export type GetMessageByIdFunction = (id: string) => Promise<ChatMessage> | |||
| export type GetMessageByIdFunction = (id: string) => Promise<ChatMessage | null> | |||
|
I'm not sure I understand the motivation around allowing these to be customized at the Thanks! |
|
@transitive-bullshit For instance, I store "enable chat history" flag in user preferences, so if it's false my upsertMessage() and getMessageById() should do nothing. But I cannot customize them on constructor level |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now custom getMessageById() and upsertMessage() can be provided only on constructor level, that makes impossible to set request-specific logic.
I propose to support those opts in sendMessage() call as well