Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run plan/apply for files ending with .hcl.json #253

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Pardeep009
Copy link

@Pardeep009 Pardeep009 commented Oct 11, 2022

Pull Request

Related Github Issues

#243

Description

The MR #246 fixes the parsing of .hcl.json files completely but still on submiting .hcl.json file the plan/apply is not able to run for the files which are ending with .hcl.json extension since as of now only files ending with

"*.hcl"
"*.tf*"

are allowed, so this MR adds .hcl.json as well so that plan/apply for .hcl.json can be run successfully.

General Implications

  • Users with .json.hcl file will be able to use terragrunt-atlantis-config.

TODO

Security Implications

  • [none]

System Availability

  • [none]

@Pardeep009
Copy link
Author

Screenshot 2022-10-13 at 2 22 08 PM

Screenshot 2022-10-13 at 2 39 17 PM

All test cases are passing in my local and the job ubuntu-latest, 1.15 has also passed.

@Pardeep009
Copy link
Author

@dmattia can you please review this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant