Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add HTTP Basic auth on the metrics endpoint #289

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zidokobik
Copy link

Referencing #283.

@gaby
Copy link

gaby commented Mar 5, 2024

@trallnag Can you take a look at this, it fixes a security issue

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.79%. Comparing base (b645ccb) to head (224b34a).
Report is 9 commits behind head on master.

❗ Current head 224b34a differs from pull request most recent head ad7b996. Consider uploading reports for the commit ad7b996 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
+ Coverage   95.68%   95.79%   +0.10%     
==========================================
  Files           5        5              
  Lines         348      357       +9     
==========================================
+ Hits          333      342       +9     
  Misses         15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trallnag trallnag marked this pull request as draft March 12, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants