Can I have it with milk?

[blazgocompany]

Yep, it's me again. I hope I'm not pestering you.

[towerofnix]

Hmm, this might be a contentious subject... of course you can have it with milk, and indeed any milk would probably be quite delicious. But is cinnamon milk truly the best? Is not the beauty of Cinnamon Toast Crunch in milk, that it flavors the milk, that its sugar-cinnamon goodness is absorbed into the milk? In this regard cinnamon milk is not only superfluous, but actually obscures that oh-so-essential cereal-milk action!

I think if we want to be a serious reference on why kids love the taste of Cinnamon Toast Crunch (and we surely do), then we might take care to acknowledge Cinnamon Toast Crunch in all its delightful dynamics.

We should also try to match the larger JavaScript ecosystem. getMilkCombinations... is a plural name, so one would expect it to return an array or otherwise iterable (such as a generator). Apart from the cinnamon-philosophical quandary above, either the function should be renamed (the export is OK), or the contents should return an iterable of milk combinations that go with cinnamon toast crunch.

Thank you for your contributions, of course!

[blazgocompany]

Great point... Ill think about it

[blazgocompany]

Your language in the first paragraph is truly amazing! I don't know if this is what you're looking for (see the commit) but I hope that's good!

[towerofnix]

Thanks, this is almost there!! I'm a stickler for literals, so can we try a syntax that's more like...

module.exports.whichMilkCanIHaveItWith =
  function* getMilkCombinations() {
    yield "with 2% milk"
    yield "with whole milk"
    yield "with almond milk"
    yield "with coconut milk"
    yield "with soy milk"
    yield "with cinnamon milk"
    yield "with your favorite milk"
    yield "or even dry"
  }

Maybe we should add an example in the examples folder too, something like this:

const getReasonWhyKidsLoveTheTasteOfCinnamonToastCrunch = require(
  'why-do-kids-love-the-taste-of-cinnamon-toast-crunch')

const getMilksICanHaveCinnamonToastCrunchWith =
      getReasonWhyKidsLoveTheTasteOfCinnamonToastCrunch.canIHaveItWithMilk

for (const milkICouldHaveItWith of getMilksICanHaveCinnamonToastCrunchWith()) {
    console.log(`I could have it ${milkICouldHaveItWith}`)
}

I don't know what to name this example though LOL. Just make sure you use an underscore (_) between each word, like the other files in the examples folder.

Also, please put a line break above the module.exports line - you can look at the picture below to see how the code you added doesn't quite fit the same style as the other ones, but that's just a simple fix.

[blazgocompany]

Ok sorry I didn't see this. Ill work on it.

[towerofnix]

Super close! Thank you! Just add a blank line above this line, please.