-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[front] feat: add buttons to compare criteria #1968
Draft
GresilleSiffle
wants to merge
49
commits into
main
Choose a base branch
from
1940-replace_sliders_by_buttons
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GresilleSiffle
changed the title
[front] feat: (WIP) add buttons to compare criteria
WIP / [front] feat: add buttons to compare criteria
May 7, 2024
… margin definition
Recent feedback from the rest of the team:
|
GresilleSiffle
changed the title
WIP / [front] feat: add buttons to compare criteria
[front] feat: add buttons to compare criteria
May 23, 2024
The branch is now ready for review. I keep the PR in draft for now, because the back end is not yet ready to process comparisons with different |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issues #1940
do not merge: the back end doesn't support comparisons with different
score_max
yetDescription
This PR adds a new comparison method for mobile devices: buttons.
Features
How the front end chooses to display buttons or sliders?
If the displayed comparison has been previously made with buttons, the buttons are displayed. If it has been rated by sliders, sliders are displayed.
If the displayed comparison is new, the button are displayed for devices not matching the media query
(pointer:fine)
, and the sliders are displayed for all other devices (See the pointer media feature).No conversion from buttons to sliders and from sliders to buttons is allowed for now.
Future improvements
to-do
front end - tutorial
front end - buttons
front end - comparison input
score_max
of the main criterion is 2score_max
of the main criterion is 10score_max
between != criteriafront end - comparison scores review
front end - comparison
front end - coherence
Preview
A "mobile" comparison displayed on desktop:
Checklist