fix migrate m2m add、change and remove #288
Open
+57
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, he can't directly create many-to-many fields when creating the table model. My mistake |
|
Please, someone take care of this |
|
I use alembic now
…---Original---
From: ***@***.***>
Date: Sat, Sep 23, 2023 12:27 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [tortoise/aerich] fix migrate m2m add、change and remove (PR #288)
Please, someone take care of this
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
just tested this on a local fork and it worked perfectly. can we please get this merged? @long2ice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dictdiffer.diffis not friendly to check the list. It can only check the difference between the elements of the same index of two lists, but theold_m2m_fieldsandnew_m2m_fieldsThe elements of these two lists are not sorted, and it is easy to compare errors. The function in this submission can sort these two lists according to thethroughkeyword. Now you can add and delete many to many fields