Answer:2 effect vs selector #912
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use new control flow Use selectSignal instead of select Consolidate border styles to a single line
Remove boilerplate selectors Move compound selector into extraSelectors
Move the effect and reducer into a new selector
refactor to have the component select once, not additionally for each activity
github-actions
bot
added
2
tomalaforge
reviewed
May 20, 2024
| } | ||
| }, []); | ||
| } | ||
| return []; |
|
Good job. The goal of this challenge is to show that selectors are very powerful and the used to derive the state. Like computed in signals. We shouldn't store derived piece of state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description said to use only one action from the component, but I used the effect lifecycle instead, so the component dispatches nothing.
Also, I used
createFeatureto simplify the selectors.Checklist for challenge submission
Warning:
Alternatively, you can still submit your PR to join the list of answered challenges or to be reviewed by a community member. 馃敟