Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenge 50: bug with conditional effects #841

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

tomalaforge
Copy link
Owner

No description provided.

@tomalaforge
Copy link
Owner Author

@svenson95 @jdegand Here is a new challenge on signal, I will try to create more of them but it's a very easy one to start.
So you have feedback on the doc page or the challenge itself 🙏

@jdegand
Copy link
Contributor

jdegand commented May 3, 2024

@tomalaforge Like the challenge. There are multiple solutions you can employ to get the alert to display after each checkbox click. This is a challenge that is easy in retrospect and requires you to dig deeper and think about how effect works.

Maybe, add template literal to the alert? Change alert('One checkbox is check') to {age} checkbox was checked etc.
Either way, I think the alert message needs to be changed (Checkbox was checked), but that's about it.

A new issue was just added to the Angular repo that relates to this challenge.

@tomalaforge tomalaforge merged commit bfe7f23 into main May 7, 2024
1 check passed
@tomalaforge tomalaforge deleted the challenge-50-effect branch May 7, 2024 12:41
### Run Application

```bash
npx nx serve angular-bug-effect-signal
Copy link
Contributor

@svenson95 svenson95 May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe angular-signal-effect-bug would fit better for the naming, to have signal as a prefix for other signal challenges as well, like the pipe challenges, which start with pipe as a prefix.

And in the title Bug in Effect ? i'd remove the space between Effect and ?. Or simply Effect Bug would be nicer imo. I'd avoid question marks in the title. Because until now there is no title with a question mark, which is not really a problem, but it looks cleaner for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants