Adding flights of packets to the knowledge and ability to decrypt a whole flight of packets #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ht decryption for all traces
LCBH
requested changes
May 29, 2024
aeyno
force-pushed
the
message_flights
branch
5 times, most recently
from
bd2bd6d
to
51de8e5
Compare
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows storing a flight of packet, eg. all packets that were sent by a PUT between two steps, in the knowledge. This flight could then be queried and used in a trace as a
Vec<Message>. This PR also adds the ability to send a Flight of packets in a trace step, which allows to send multiple packets at once.This is needed to make the traces less dependent of implementation choices and to be resilient if some implementations choose to fragment their packets in different ways.
The first use case is to create traces that work both for OpenSSL/WolfSSL/LibreSSL and BoringSSL, the latter fragmenting his handshake messages differently than the formers.