Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on error log sibling too #621

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

on error log sibling too #621

wants to merge 1 commit into from

Conversation

tomato42
Copy link
Member

@tomato42 tomato42 commented Dec 2, 2019 •
edited

Description

one of the identifying properties of a node is the sibling
(especially for NewSessionTicket), so do include it in error message

Motivation and Context

nicer debugging of test failures involving more complex message structures

Checklist

  • I have read the CONTRIBUTING.md document and my PR follows change requirements therein
  • the changes are also reflected in documentation and code comments
  • all new and existing tests pass (see Travis CI results)
  • test script checklist was followed for new scripts
  • new test script added to tlslite-ng.json and tlslite-ng-random-subset.json
  • new and modified scripts were ran against popular TLS implementations:
    • n/a
  • required version of tlslite-ng updated in requirements.txt and README.md

This change is Reviewable

@tomato42 tomato42 added the enhancement new feature to be implemented label Dec 2, 2019
@tomato42 tomato42 self-assigned this Dec 2, 2019
@tomato42
log sibling too
45e7718 
one of the identifying properties of a node is the sibling
(especially for NewSessionTicket), so do include it in error message
@tomato42 tomato42 changed the title log sibling too on error log sibling too Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tomato42 tomato42

Labels
enhancement new feature to be implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tomato42