Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scd: add page #9224

Merged
merged 24 commits into from
Jan 3, 2023
Merged

scd: add page #9224

merged 24 commits into from
Jan 3, 2023

Conversation

jay-tau
Copy link
Contributor

@jay-tau jay-tau commented Oct 21, 2022

Completes a task in #3689

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 21, 2022
@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@kbdharun kbdharun changed the title scd: Add page sam2p, scd: Add page Oct 22, 2022
@kbdharun kbdharun changed the title sam2p, scd: Add page sam2p, scd: add page Oct 22, 2022
@kbdharun kbdharun changed the title sam2p, scd: add page scd: add page Oct 22, 2022
@kbdharun
Copy link
Member

kbdharun commented Oct 22, 2022

Seems like you accidentally added sam2p to this PR too. Can you remove it?

Ref #9109

Edit: Removed it

Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I have some suggestions for this page.

pages/common/scd.md Outdated Show resolved Hide resolved
pages/common/scd.md Outdated Show resolved Hide resolved
pages/common/scd.md Outdated Show resolved Hide resolved
pages/common/scd.md Outdated Show resolved Hide resolved
@tldr-bot

This comment was marked as outdated.

jay-tau and others added 4 commits October 22, 2022 15:39
Co-authored-by: K.B.Dharun Krishna <[email protected]>
Co-authored-by: K.B.Dharun Krishna <[email protected]>
Co-authored-by: K.B.Dharun Krishna <[email protected]>
Co-authored-by: K.B.Dharun Krishna <[email protected]>
@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

@tldr-bot

This comment was marked as outdated.

pages/common/scd.md Outdated Show resolved Hide resolved
Co-authored-by: K.B.Dharun Krishna <[email protected]>
@jay-tau jay-tau closed this Oct 23, 2022
@kbdharun
Copy link
Member

@jay-tau Was this PR closed by accident?

@jay-tau jay-tau reopened this Oct 23, 2022
pages/common/scd.md Outdated Show resolved Hide resolved
pages/common/scd.md Outdated Show resolved Hide resolved

`scd {{path/to/directory}}`

- Change to a path matching all of "a", "b" and "c":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give an specific example of this to understand?

pages/common/scd.md Outdated Show resolved Hide resolved
pages/common/scd.md Outdated Show resolved Hide resolved
pages/common/scd.md Outdated Show resolved Hide resolved
pages/common/scd.md Outdated Show resolved Hide resolved
jay-tau and others added 6 commits October 27, 2022 10:04
Co-authored-by: Axel Navarro <[email protected]>
Co-authored-by: Axel Navarro <[email protected]>
Co-authored-by: Axel Navarro <[email protected]>
Co-authored-by: Axel Navarro <[email protected]>
Co-authored-by: Axel Navarro <[email protected]>
Co-authored-by: Axel Navarro <[email protected]>
@kbdharun kbdharun added the hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. label Oct 31, 2022
@github-actions
Copy link

Hi all! This thread has not had any recent activity.
Are there any updates? Thanks!

@github-actions github-actions bot added the waiting Issues/PRs with Pending response by the author. label Dec 14, 2022
Copy link
Contributor

@EmilyGraceSeville7cf EmilyGraceSeville7cf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mandatory fixes found, changes requested.
Thanks for a contribution! ❤️


- Index paths recursively for the very first run:

`scd -ar {{path/to/directory}}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mandatory fix: use long options if they are portable.
Optional fix: potentially missing mnemonic.
Note: parsing -ar failed: can't understand whether -a and -r passed or -a with r value.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jay-tau, please reply to all my unresolved conversations. :) As README doesn't provide enough info about supported options I assume that long ones exist and requesting changes based on this assumption.

pages/common/scd.md Outdated Show resolved Hide resolved
pages/common/scd.md Outdated Show resolved Hide resolved
pages/common/scd.md Outdated Show resolved Hide resolved
pages/common/scd.md Outdated Show resolved Hide resolved
Comment on lines +22 to +24
- Show selection menu and ranking of 20 most likely directories:

`scd -v`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pages/common/scd.md Outdated Show resolved Hide resolved
pages/common/scd.md Outdated Show resolved Hide resolved
Co-authored-by: Emily Grace Seville <[email protected]>
@github-actions github-actions bot removed the waiting Issues/PRs with Pending response by the author. label Dec 14, 2022
jay-tau and others added 5 commits December 14, 2022 22:12
Co-authored-by: Emily Grace Seville <[email protected]>
Co-authored-by: Emily Grace Seville <[email protected]>
Co-authored-by: Emily Grace Seville <[email protected]>
Co-authored-by: Emily Grace Seville <[email protected]>
Co-authored-by: Emily Grace Seville <[email protected]>
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/scd.md:17: TLDR011 Page never contains more than a single empty line

Please fix the error(s) and push again.

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/scd.md:17: TLDR011 Page never contains more than a single empty line

Please fix the error(s) and push again.

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/scd.md:17: TLDR011 Page never contains more than a single empty line

Please fix the error(s) and push again.

pages/common/scd.md Outdated Show resolved Hide resolved
Co-authored-by: Emily Grace Seville <[email protected]>
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/scd.md:17 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Show selection menu and rank..."]
pages/common/scd.md:17: TLDR007 Example descriptions should be surrounded by empty lines

Please fix the error(s) and push again.

Copy link
Contributor

@EmilyGraceSeville7cf EmilyGraceSeville7cf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested due to syntax error.

pages/common/scd.md Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Dec 28, 2022

CLA assistant check
All committers have signed the CLA.

Co-authored-by: Emily Grace Seville <[email protected]>
@EmilyGraceSeville7cf EmilyGraceSeville7cf merged commit 9eea977 into tldr-pages:main Jan 3, 2023
@jay-tau jay-tau deleted the add-scd branch January 3, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants