Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-s3api: add page #6132

Merged
merged 11 commits into from Jun 23, 2021
Merged

aws-s3api: add page #6132

merged 11 commits into from Jun 23, 2021

Conversation

258204
Copy link
Collaborator

@258204 258204 commented Jun 16, 2021 •
edited by bl-ue

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

For #5653

@CleanMachine1 CleanMachine1 added the new command Issues requesting creation of a new page. label Jun 16, 2021
@tldr-bot

This comment has been minimized.

Sign in to view
bl-ue
bl-ue suggested changes Jun 16, 2021
View reviewed changes
pages/common/aws-s3api.md Outdated Show resolved Hide resolved
pages/common/aws-s3api.md Outdated Show resolved Hide resolved
pages/common/aws-s3api.md Outdated Show resolved Hide resolved
pages/common/aws-s3api.md Outdated Show resolved Hide resolved
@bl-ue bl-ue mentioned this pull request Jun 16, 2021
Open
mfrw
mfrw reviewed Jun 17, 2021
View reviewed changes
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.
I have few cosmetic nitpicks :)

pages/common/aws-s3api.md Outdated Show resolved Hide resolved
pages/common/aws-s3api.md Outdated Show resolved Hide resolved
258204 and others added 3 commits June 18, 2021 09:58
@bl-ue
Copy link
Contributor

bl-ue commented Jun 21, 2021

@marchersimon & @mfrw: can you please approve?

marchersimon
marchersimon approved these changes Jun 23, 2021
View reviewed changes
Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

sbrl
sbrl approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @258204!

@sbrl sbrl merged commit a01df47 into tldr-pages:main Jun 23, 2021
@258204 258204 deleted the aws-s3api branch November 28, 2021 02:48
@navarroaxel navarroaxel mentioned this pull request Dec 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bl-ue bl-ue bl-ue approved these changes

@navarroaxel navarroaxel navarroaxel approved these changes

@sbrl sbrl sbrl approved these changes

@marchersimon marchersimon marchersimon approved these changes

@mfrw mfrw Awaiting requested review from mfrw

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@258204 @tldr-bot @bl-ue @navarroaxel @mfrw @sbrl @marchersimon @CleanMachine1