Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r2e: add page #4240

Merged
merged 8 commits into from
Aug 9, 2020
Merged

r2e: add page #4240

merged 8 commits into from
Aug 9, 2020

Conversation

samuel-w
Copy link
Contributor

@samuel-w samuel-w commented Jul 31, 2020

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Part of #3689

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

Error: Parse error on line 5:
...s2email/rss2email.> Requires a configu
---------------------^
Expecting 'TEXT', 'DASH', 'BACKTICK', got 'GREATER_THAN'

Please fix the error(s) and push again.

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/r2e.md:4: TLDR004 Command descriptions should end in a period
pages/common/r2e.md:6: TLDR005 Example descriptions should end in a colon
pages/common/r2e.md:10: TLDR005 Example descriptions should end in a colon
pages/common/r2e.md:14: TLDR005 Example descriptions should end in a colon
pages/common/r2e.md:18: TLDR005 Example descriptions should end in a colon
pages/common/r2e.md:22: TLDR005 Example descriptions should end in a colon

Please fix the error(s) and push again.

@sbrl sbrl added the new command Issues requesting creation of a new page. label Aug 2, 2020
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page, @samuel-w! I've left some comments below for you to review.

pages/common/r2e.md Outdated Show resolved Hide resolved
pages/common/r2e.md Outdated Show resolved Hide resolved
pages/common/r2e.md Outdated Show resolved Hide resolved
pages/common/r2e.md Outdated Show resolved Hide resolved
samuel-w and others added 4 commits August 2, 2020 14:21
Co-authored-by: Starbeamrainbowlabs <[email protected]>
Co-authored-by: Starbeamrainbowlabs <[email protected]>
Co-authored-by: Starbeamrainbowlabs <[email protected]>
Co-authored-by: Starbeamrainbowlabs <[email protected]>
Copy link
Member

@einverne einverne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @samuel-w for this new page. It looks good to me.

@samuel-w samuel-w requested a review from sbrl August 3, 2020 01:30
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @samuel-w :D

@sbrl sbrl merged commit 2ead707 into tldr-pages:master Aug 9, 2020
@samuel-w samuel-w deleted the r2e branch August 10, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants