Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow CI to run when PDFs haven't been generated #12669

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

acuteenvy
Copy link
Member

The CI fails if no PDF files have been generated, because "$PDFS/"*.pdf doesn't match anything. nullglob makes these unmatched patterns expand to nothing instead of throwing an error.

Closes #12661.

@github-actions github-actions bot added the tooling Helper tools, scripts and automated processes. label Apr 23, 2024
Copy link
Member

@vitorhcl vitorhcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at first sight, i.e., the solution seems fine if the glob issue is in fact / the only problem.

I'm gonna take a closer look at it if any problem is found in this PR after closing #12506.

@acuteenvy acuteenvy force-pushed the ci-bug-12661 branch 2 times, most recently from e586890 to f25690c Compare April 23, 2024 22:28
@kbdharun kbdharun self-requested a review April 24, 2024 07:37
@sebastiaanspeck sebastiaanspeck merged commit b9941d2 into tldr-pages:main Apr 25, 2024
4 checks passed
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry wasn't able to look this over on time, LGTM and thanks for the fix.

@acuteenvy acuteenvy deleted the ci-bug-12661 branch April 25, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Helper tools, scripts and automated processes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: deploy script fails CI when a languages doesn't generate a PDF file
5 participants