yt-dlp: update page #12580

thrila · 2024-03-30T01:18:23Z

The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
The page(s) have at most 8 examples.
The page description(s) have links to documentation or a homepage.
The page(s) follow the content guidelines.
The PR title conforms to the recommended templates.
Version of the command being documented (if known):

thrila · 2024-03-30T01:20:56Z

@kbdharun please confirm

CleanMachine1 · 2024-03-30T02:06:22Z

pages/common/yt-dlp.md

@@ -8,11 +8,11 @@

 `yt-dlp "{{https://www.youtube.com/watch?v=oHg5SJYRHA0}}"`

- List the available downloadable formats for a video:
+- List all formats that a video or playlist is available in:


removes some clarity, unnecessary.

CleanMachine1 · 2024-03-30T02:06:45Z

pages/common/yt-dlp.md


 `yt-dlp --list-formats "{{https://www.youtube.com/watch?v=oHg5SJYRHA0}}"`

- Download a video with a defined format, in this case the best mp4 video available (default is "bv\*+ba/b"):
+- Download a video or playlist at a specific quality:


This has removed key information to the user, why?

CleanMachine1 · 2024-03-30T02:09:52Z

pages/common/yt-dlp.md


 - Download all playlists of YouTube channel/user keeping each playlist in separate directory:

-`yt-dlp -o "{{%(uploader)s/%(playlist)s/%(playlist_index)s - %(title)s.%(ext)s}}" "{{https://www.youtube.com/user/TheLinuxFoundation/playlists}}"`
+`yt-dlp -o "{{%(uploader)s/%(playlist)s/%(playlist_index)s - %(title)s.%(ext)s}}" "{{url}}"`


this isn't the best of changes, how is the user to know that a playlist is needed

I agree.

@thrila we try to be as clear as possible, and we use descriptive placeholder. I don't see any benefits on removing the example from the placeholder.

What about reverting this change?

CleanMachine1 · 2024-03-30T02:10:13Z

pages/common/yt-dlp.md


 - Download Udemy course keeping each chapter in separate directory under MyVideos directory in your home:

-`yt-dlp -u {{user}} -p {{password}} -P "{{~/MyVideos}}" -o "{{%(playlist)s/%(chapter_number)s - %(chapter)s/%(title)s.%(ext)s}}" "{{https://www.udemy.com/java-tutorial}}"`
+`yt-dlp -u {{user}} -p {{password}} -P "{{~/MyVideos}}" -o "{{%(playlist)s/%(chapter_number)s - %(chapter)s/%(title)s.%(ext)s}}" "{{url}}"`

 - Download entire series season keeping each series and each season in separate directory under C:/MyVideos:


This actually needs changing, its windows specific for a common page

thrila · 2024-03-30T02:20:41Z

Thanks for the correction

fazlearefin · 2024-03-30T06:00:45Z

pages/common/yt-dlp.md


 - Download entire series season keeping each series and each season in separate directory under C:/MyVideos:

-`yt-dlp -P "{{C:/MyVideos}}" -o "{{%(series)s/%(season_number)s - %(season)s/%(episode_number)s - %(episode)s.%(ext)s}}" "{{https://videomore.ru/kino_v_detalayah/5_sezon/367617}}"`
+`yt-dlp -P "{{C:/MyVideos}}" -o "{{%(series)s/%(season_number)s - %(season)s/%(episode_number)s - %(episode)s.%(ext)s}}" "{{url}}"`


Suggested change

`yt-dlp -P "{{C:/MyVideos}}" -o "{{%(series)s/%(season_number)s - %(season)s/%(episode_number)s - %(episode)s.%(ext)s}}" "{{url}}"`

`yt-dlp -P "{{path/to/directory}}" -o "{{%(series)s/%(season_number)s - %(season)s/%(episode_number)s - %(episode)s.%(ext)s}}" "{{url}}"`

Please see https://github.com/tldr-pages/tldr/blob/main/contributing-guides/style-guide.md#paths

FYI, this was marked as resolved without any commits being added.
Do not close comments from maintainers without discussing or doing the suggested change.

Magrid0

Looks good to me

kbdharun · 2024-03-30T15:02:49Z

pages/common/yt-dlp.md

@@ -22,16 +22,16 @@

 - Specify audio format and audio quality of extracted audio (between 0 (best) and 10 (worst), default = 5):

-`yt-dlp --extract-audio --audio-format {{mp3}} --audio-quality {{0}} "{{https://www.youtube.com/watch?v=oHg5SJYRHA0}}"`
+`yt-dlp --extract-audio --audio-format {{mp3}} --audio-quality {{0}} "{{url}}"`


Thanks for your contribution. Can you update the same in other examples?

What other examples?

What other examples?

The placeholder examples for URL above.

CleanMachine1 · 2024-04-02T00:54:35Z

You did not make any changes following my comments, and then proceeded to close them, saying they have been resolved.

Please actually respond to them appropriately.

CleanMachine1

Please do not approve before actually reading and commenting on my original feedback.

thrila · 2024-04-02T01:01:35Z

my apologies started using github mobile seems im yet to fully understand it , still i thought the change you made was changing the placeholder url to the keyword url

CleanMachine1 · 2024-04-12T23:48:24Z

Do you plan on changing anything suggested, or should we close this PR?

thrila · 2024-04-13T00:16:31Z

Do you plan on changing anything suggested, or should we close this PR?

yeah lemme do it now kinda forgot

thrila · 2024-04-13T01:29:47Z

Do you plan on changing anything suggested, or should we close this PR?

Hi finished do you mind checking?

CleanMachine1 · 2024-04-13T14:16:28Z

That commit has nothing in it, did you not push your changes?

thrila · 2024-04-17T00:15:48Z

That commit has nothing in it, did you not push your changes?

Seems i didnt my bad haven't really contributed to a project before Thanks for the patience

vitorhcl · 2024-04-23T21:11:59Z

pages/common/yt-dlp.md


 `yt-dlp --list-formats "{{https://www.youtube.com/watch?v=oHg5SJYRHA0}}"`

- Download a video with a defined format, in this case the best mp4 video available (default is "bv\*+ba/b"):
+- Download a video or playlist at a specific quality:


Suggested change

- Download a video or playlist at a specific quality:

- Download a video or playlist using best MP4 video available (default is "bv\*+ba/b"):

What about this? I agree with @CleanMachine1, your change removes key information for the user.

thrila · 2024-05-05T23:12:27Z

Any more corrections?

CleanMachine1 · 2024-05-06T01:10:46Z

I think you are making a mistake with adding the changes, could you share what commands you are running/what you are doing to make the suggested changes.

vitorhcl · 2024-05-06T02:56:08Z

I think he is just merging the branch instead of commit the changes.

@thrila if you are on GitHub Mobile, you meed to click on the comments and then click om the "Commit" button.

thrila · 2024-05-06T08:22:53Z

I am on mobile thanks for the tip
Still there's one thing that confuses me
As you can see from the last stream of commits the placeholder was removed and a example URL was placed I don't know if this is something he did for all of them how do I check? Other than that I actually started with an example URL and some dudes said a place holder was better when I made a PR

vitorhcl · 2024-05-07T21:50:56Z

Still there's one thing that confuses me
As you can see from the last stream of commits the placeholder was removed and a example URL was placed

I saw the last commits and it looks like it's the opposite, you replaced the example URLs with the generic placeholder text "url".

I don't know if this is something he did for all of them how do I check?

Well, the current state is replacing some examples URLs with the "url" placeholder.

Anyways, you can see the changes that would be applied if thisnPR was merged clicking on the first bar below the PR description that has green and red numbers (the quantity of modified lines).

Green = addition, red = removal.

Other than that I actually started with an example URL and some dudes said a place holder was better when I made a PR

Are you talking about #12580 (comment)? I don't know if @kbdharun thinks it is a good idea or if that was just a suggestion for improving the page consistency.

In my opinion, in this case, example URLs are more user-friendly.

kbdharun · 2024-05-09T09:52:07Z

Are you talking about #12580 (comment)? I don't know if @kbdharun thinks it is a good idea or if that was just a suggestion for improving the page consistency.

Agreed, having example URLs seems much better. I wasn't clear in my previous review comment, what I meant is since one example was updated to the URL I suggested updating it throughout the page or reverting the link in the specific line (in this case, reverting seems like the best course of action).

thrila and others added 3 commits October 5, 2023 12:58

yt-dlp: refactor ytdlp page in youtube-dl format

6e469ba

yt-dlp: remove incidental extra space

a37f211

Merge branch 'tldr-pages:main' into main

2590579

github-actions bot added the page edit Changes to an existing page(s). label Mar 30, 2024

CleanMachine1 requested changes Mar 30, 2024

View reviewed changes

fazlearefin reviewed Mar 30, 2024

View reviewed changes

Magrid0 approved these changes Mar 30, 2024

View reviewed changes

kbdharun changed the title ~~chore: add page for yt-dlp~~ yt-dlp: update page Mar 30, 2024

kbdharun reviewed Mar 30, 2024

View reviewed changes

CleanMachine1 requested changes Apr 2, 2024

View reviewed changes

Merge branch 'tldr-pages:main' into main

845c4ff

thrila closed this Apr 13, 2024

thrila reopened this Apr 13, 2024

Merge branch 'tldr-pages:main' into main

52be391

vitorhcl requested changes Apr 23, 2024

View reviewed changes

Merge branch 'main' into main

b92be93

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

yt-dlp: update page #12580

yt-dlp: update page #12580

thrila commented Mar 30, 2024

thrila commented Mar 30, 2024

CleanMachine1 Mar 30, 2024

CleanMachine1 Mar 30, 2024

CleanMachine1 Mar 30, 2024

vitorhcl Apr 23, 2024

CleanMachine1 Mar 30, 2024

thrila commented Mar 30, 2024

fazlearefin Mar 30, 2024

CleanMachine1 Apr 2, 2024

Magrid0 left a comment

kbdharun Mar 30, 2024

thrila Mar 30, 2024

kbdharun Mar 31, 2024 •

edited

CleanMachine1 commented Apr 2, 2024

CleanMachine1 left a comment

thrila commented Apr 2, 2024

CleanMachine1 commented Apr 12, 2024

thrila commented Apr 13, 2024

thrila commented Apr 13, 2024

CleanMachine1 commented Apr 13, 2024

thrila commented Apr 17, 2024

vitorhcl Apr 23, 2024

thrila commented May 5, 2024

CleanMachine1 commented May 6, 2024

vitorhcl commented May 6, 2024

thrila commented May 6, 2024

vitorhcl commented May 7, 2024

kbdharun commented May 9, 2024 •

edited

	`yt-dlp -P "{{C:/MyVideos}}" -o "{{%(series)s/%(season_number)s - %(season)s/%(episode_number)s - %(episode)s.%(ext)s}}" "{{url}}"`
	`yt-dlp -P "{{path/to/directory}}" -o "{{%(series)s/%(season_number)s - %(season)s/%(episode_number)s - %(episode)s.%(ext)s}}" "{{url}}"`

	- Download a video or playlist at a specific quality:
	- Download a video or playlist using best MP4 video available (default is "bv\*+ba/b"):

yt-dlp: update page #12580

Are you sure you want to change the base?

yt-dlp: update page #12580

Conversation

thrila commented Mar 30, 2024

thrila commented Mar 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thrila commented Mar 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Magrid0 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kbdharun Mar 31, 2024 • edited

Choose a reason for hiding this comment

CleanMachine1 commented Apr 2, 2024

CleanMachine1 left a comment

Choose a reason for hiding this comment

thrila commented Apr 2, 2024

CleanMachine1 commented Apr 12, 2024

thrila commented Apr 13, 2024

thrila commented Apr 13, 2024

CleanMachine1 commented Apr 13, 2024

thrila commented Apr 17, 2024

Choose a reason for hiding this comment

thrila commented May 5, 2024

CleanMachine1 commented May 6, 2024

vitorhcl commented May 6, 2024

thrila commented May 6, 2024

vitorhcl commented May 7, 2024

kbdharun commented May 9, 2024 • edited

kbdharun Mar 31, 2024 •

edited

kbdharun commented May 9, 2024 •

edited