Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fitstopnm, pamcut, pamdeinterlace, pamdice, pammixinterlace, pamtofits, pamundice, pnmtofits: add pages #12296

Merged
merged 7 commits into from
Feb 22, 2024

Conversation

gutjuri
Copy link
Member

@gutjuri gutjuri commented Feb 18, 2024

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Feb 18, 2024
@gutjuri gutjuri mentioned this pull request Feb 18, 2024
Copy link
Member

@vitorhcl vitorhcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I will review it carefully when I have the time, but I already have some suggestions

pages/common/fitstopnm.md Outdated Show resolved Hide resolved
pages/common/pamcut.md Outdated Show resolved Hide resolved
pages/common/pamtofits.md Outdated Show resolved Hide resolved

- Combine the images whose names match the `printf`-style filename expression. Assume a grid of size `x_value` times `y_value`:

`pamundice {{filename_%1d_%1a.ppm}} -across {{x_value}} -down {{y_value}} > {{path/to/output.ppm}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it doesn't support a path as an argument?

Copy link
Member

@vitorhcl vitorhcl Feb 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can address the filename vs path/to/file issue on another PR


- Assume that the tiles overlap horizontally and vertically by the specified amount:

`pamundice {{filename_%1d_%1a.ppm}} -across {{x_value}} -down {{y_value}} -hoverlap {{value}} -voverlap {{value}} > {{path/to/output.ppm}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it doesn't support a path as an argument?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, i'm not entirely sure whether or not it does. It is not included in the Netpbm bundle on my computer, so I can't test.

pages/common/pamcut.md Show resolved Hide resolved
pages/common/pamcut.md Show resolved Hide resolved
pages/common/pamcut.md Show resolved Hide resolved
pages/common/fitstopnm.md Outdated Show resolved Hide resolved
@vitorhcl
Copy link
Member

BTW, excellent work on this "Let's document", it's good to know that this PR will close it.

Copy link
Member Author

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked that this one takes a path argument.

pages/common/pamdice.md Outdated Show resolved Hide resolved
@gutjuri
Copy link
Member Author

gutjuri commented Feb 18, 2024

BTW, excellent work on this "Let's document", it's good to know that this PR will close it.

Thanks. However, since the Netpbm version installed on my system is not the latest version, #10887 does not contain all commands in Netpbm :( I think I'll will open another issue for the new commands. The old one has grown quite large.

@vitorhcl
Copy link
Member

Thanks. However, since the Netpbm version installed on my system is not the latest version, #10887 does not contain all commands in Netpbm :( I think I'll will open another issue for the new commands. The old one has grown quite large.

Yeah I just saw there's much more commands 😅 you can use the Arch Linux package list to easily make a new "Let's document"

Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@vitorhcl vitorhcl self-requested a review February 19, 2024 19:58
Copy link
Member

@vitorhcl vitorhcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I have some suggestions

pages/common/fitstopnm.md Outdated Show resolved Hide resolved

- Combine the images whose names match the `printf`-style filename expression. Assume a grid of size `x_value` times `y_value`:

`pamundice {{filename_%1d_%1a.ppm}} -across {{x_value}} -down {{y_value}} > {{path/to/output.ppm}}`
Copy link
Member

@vitorhcl vitorhcl Feb 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can address the filename vs path/to/file issue on another PR

pages/common/pamundice.md Outdated Show resolved Hide resolved
pages/common/pamundice.md Outdated Show resolved Hide resolved
pages/common/fitstopnm.md Outdated Show resolved Hide resolved
pages/common/pamtofits.md Outdated Show resolved Hide resolved
@gutjuri gutjuri merged commit acafa88 into tldr-pages:main Feb 22, 2024
4 checks passed
@gutjuri gutjuri deleted the add-pamdice branch February 22, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants