Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pbmtoascii: add page #11289

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Conversation

deadpyxel
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

This should progress #10887

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 26, 2023
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/pbmtoascii.md:3: TLDR003 Descriptions should start with a capital letter

Please fix the error(s) and push again.

@deadpyxel deadpyxel marked this pull request as ready for review October 26, 2023 15:40
@deadpyxel
Copy link
Contributor Author

Not really sure if I should have rebased to keep a cleaner history. If so please let me know

@sebastiaanspeck
Copy link
Member

The commits will be squashed eventually so it doesn't matter that much

Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution. I have added some suggestions.

pages/common/pbmtoascii.md Outdated Show resolved Hide resolved
pages/common/pbmtoascii.md Outdated Show resolved Hide resolved
pages/common/pbmtoascii.md Outdated Show resolved Hide resolved
pages/common/pbmtoascii.md Outdated Show resolved Hide resolved
@gutjuri gutjuri mentioned this pull request Oct 26, 2023
@gutjuri gutjuri changed the title pmbtoascii: add page pbmtoascii: add page Oct 26, 2023
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I have some suggestions for this page.

pages/common/pbmtoascii.md Outdated Show resolved Hide resolved
pages/common/pbmtoascii.md Outdated Show resolved Hide resolved
Co-authored-by: Juri Dispan <[email protected]>
Co-authored-by: K.B.Dharun Krishna <[email protected]>
@deadpyxel
Copy link
Contributor Author

This command in particular just accepts -1x2 and -2x4. Should we reflect that on the page?

@kbdharun
Copy link
Member

This command in particular just accepts -1x2 and -2x4. Should we reflect that on the page?

Yep, let me add a quick suggestion for it.

reformat command to it is clear that only two options are supported

Co-authored-by: K.B.Dharun Krishna <[email protected]>
@sebastiaanspeck sebastiaanspeck merged commit d5b638c into tldr-pages:main Oct 26, 2023
4 checks passed
@deadpyxel deadpyxel deleted the add-pbmtoascii-page branch October 26, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants