Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BSD and macos platforms to --platform option #236

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

owenvoke
Copy link
Member

@owenvoke owenvoke commented Feb 26, 2024

Closes #234 and closes #235

@owenvoke owenvoke changed the title feat: add BSD platforms to --platform option feat: add BSD and macos platforms to --platform option Feb 26, 2024
@acuteenvy
Copy link
Member

This doesn't work, because macos is not a directory. tldr --platform macos <page_name> always prints "documentation is not available".

There's also android, which isn't on the list here.

@owenvoke
Copy link
Member Author

owenvoke commented Feb 26, 2024

Ah, so we need to actually alias it. Will mark this as draft and work on the required changes.

I'll add Android as well. I feel like it's a bit redundant duplicating the platforms here though, so perhaps we can extract to a variable or something.

@owenvoke owenvoke marked this pull request as draft February 26, 2024 19:01
@kbdharun
Copy link
Member

Hi, any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BSDs are supported, but cannot be passed to the --platform option The macos alias for osx is not supported
3 participants