Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require argument parameters #359

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Require argument parameters #359

wants to merge 4 commits into from

Conversation

vladimyr
Copy link
Collaborator

Description

Require argument parameters and limit -o, --os argument choices.
(Bumps commander to v8.)

/cc @marchersimon

Checklist

Please review this checklist before submitting a pull request.

  • Code compiles correctly
  • Created tests, if possible
  • All tests passing (npm run test:all)
  • Extended the README / documentation, if necessary

@vladimyr vladimyr changed the title Revert "Fix missing render path error (#354)" Require argument parameters Jun 30, 2021
marchersimon
marchersimon approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

owenvoke
owenvoke reviewed Jul 1, 2021
View reviewed changes
lib/errors.js Outdated Show resolved Hide resolved
@kbdharun kbdharun requested a review from owenvoke August 20, 2023 05:36
@kbdharun kbdharun changed the base branch from master to main October 3, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueskyson blueskyson blueskyson approved these changes

@marchersimon marchersimon marchersimon approved these changes

@owenvoke owenvoke Awaiting requested review from owenvoke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vladimyr @owenvoke @blueskyson @marchersimon