allow "Location" header #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HTTP headers are case-insensitive (RFC9110 Sec 5.1 Field Names). I was under the assumption that Faraday already does header name normalisation, but maybe that's not the case, or there is something else to do on this end 🤔 Need to do some digging and testing, thanks for reporting 🙇 |
|
It's my fault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using this Gem, I encountered an issue where it inexplicably did not follow redirects properly.
After investigating the cause, I found that the web server uses the
"Location"header.According to RFC7231, it is written as
Location, and I believe we should support this as well, so I created a pull request.