os.FindProcess, process.Release #4218
Open
+59
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leongross
force-pushed
the
os/FindProcess
branch
2 times, most recently
from
b27bafa
to
dd061d8
Compare
Signed-off-by: leongross <[email protected]>
leongross
force-pushed
the
os/FindProcess
branch
2 times, most recently
from
91b9c03
to
2f2caa6
Compare
aykevl
reviewed
May 14, 2024
src/os/exec_test.go
Outdated
Comment on lines
14
to
15
| // NOTE: For now, we only test the Linux case since only exec_posix.go is currently the only implementation. | ||
| if runtime.GOOS == "linux" { |
There was a problem hiding this comment.
exec_posix.go does in fact include Windows, and because it's all no-ops anyway I think it would be fine to test this on any platform (including Windows).
There was a problem hiding this comment.
that makes sense, I will remove it
Signed-off-by: leongross <[email protected]>
Signed-off-by: leongross <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation of
os.FindProcessprovides minimal functionality while being aligned to the process design pattern oftinygo.