os/user.Lookup #4217
os/user.Lookup #4217
Conversation
leongross
force-pushed
the
os/user/Lookup
branch
from
4826227
to
3c925ed
Compare
|
@deadprogram any thoughts on this? |
|
@deadprogram do you have any recommendations on what to improve or does this look good to you? |
|
@aykevl maybe you can have a short look at this? |
|
ping for review |
|
Just waiting for #4027 to land before any more changes to this part of the code. |
Signed-off-by: leongross <[email protected]>
leongross
force-pushed
the
os/user/Lookup
branch
3 times, most recently
from
6c8cf91
to
d9ef0e1
Compare
|
for some reason smoke test |
That's #4206 |
There was a problem hiding this comment.
I guess this was mostly copied from upstream Go, correct?
The code looks reasonable, though I would prefer if the test was actually being run (you can add it to GNUmakefile, see TEST_PACKAGES_FAST and related variables). Also, what about MacOS/Windows/baremetal support? Does it just fail to compile? I'm worried we might be breaking some existing programs that currently work.
Signed-off-by: leongross <[email protected]>
Add support for User lookup via
os/user.Lookup()