Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crypto polyfills back #102

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AaronDewes
Copy link

@AaronDewes AaronDewes commented Aug 10, 2022

Fixes #101 (comment)

Please test this before merging, I haven't tested it myself yet

@timvisee
Copy link
Owner

timvisee commented Aug 11, 2022

This doesn't seem to fix it.

Now I'm seeing the following browser console error:

./node_modules/asmcrypto.js/asmcrypto.all.es8.js
Module build failed (from (webpack)-unassert-loader/index.js):
Error: Line 10343: Unexpected token
    at ErrorHandler.constructError (/home/timvisee/git/send/node_modules/esprima/dist/esprima.js:5012:22)
    at ErrorHandler.createError (/home/timvisee/git/send/node_modules/esprima/dist/esprima.js:5028:27)
    at Parser.unexpectedTokenError (/home/timvisee/git/send/node_modules/esprima/dist/esprima.js:1985:39)
    at Parser.tolerateUnexpectedToken (/home/timvisee/git/send/node_modules/esprima/dist/esprima.js:1998:42)
    at Parser.parseStatementListItem (/home/timvisee/git/send/node_modules/esprima/dist/esprima.js:3365:31)
    at Parser.parseScript (/home/timvisee/git/send/node_modules/esprima/dist/esprima.js:4723:29)
    at Object.parse (/home/timvisee/git/send/node_modules/esprima/dist/esprima.js:122:61)
    at Object.module.exports (/home/timvisee/git/send/node_modules/webpack-unassert-loader/index.js:20:21)

I just confirmed that 64644b5 is indeed the first bad commit.

Repository owner deleted a comment from bitfactory-tim-visee Aug 11, 2022
@AaronDewes
Copy link
Author

Can you check if this version works? It did not throw any errors for me locally.

@timvisee
Copy link
Owner

timvisee commented Aug 11, 2022

Can you check if this version works? It did not throw any errors for me locally.

Still errors, sadly. This happens when I start the upload:

Uncaught (in promise) Error: Unrecognized name
    Cr http://local.timvisee.com:8080/90.37dd12f0.js:12
    Nr http://local.timvisee.com:8080/90.37dd12f0.js:12
    getProvider http://local.timvisee.com:8080/90.37dd12f0.js:12
    importKey http://local.timvisee.com:8080/90.37dd12f0.js:12
    liner http://local.timvisee.com:8080/90.37dd12f0.js:12
    liner http://local.timvisee.com:8080/90.37dd12f0.js:12
    ar http://local.timvisee.com:8080/90.37dd12f0.js:12
    wrapNative http://local.timvisee.com:8080/90.37dd12f0.js:12
    liner http://local.timvisee.com:8080/90.37dd12f0.js:12
    liner http://local.timvisee.com:8080/90.37dd12f0.js:12
    ar http://local.timvisee.com:8080/90.37dd12f0.js:12
    importKey http://local.timvisee.com:8080/90.37dd12f0.js:12
    Keychain http://local.timvisee.com:8080/app.6e75a70b.js:21463
    FileSender http://local.timvisee.com:8080/app.6e75a70b.js:18998
    default http://local.timvisee.com:8080/app.6e75a70b.js:10768
    _emit http://local.timvisee.com:8080/app.6e75a70b.js:119501
    emit http://local.timvisee.com:8080/app.6e75a70b.js:119393
    upload http://local.timvisee.com:8080/app.6e75a70b.js:59883
Error: Unrecognized name
    Cr http://local.timvisee.com:8080/90.37dd12f0.js:12
    Nr http://local.timvisee.com:8080/90.37dd12f0.js:12
    getProvider http://local.timvisee.com:8080/90.37dd12f0.js:12
    importKey http://local.timvisee.com:8080/90.37dd12f0.js:12
    liner http://local.timvisee.com:8080/90.37dd12f0.js:12
    liner http://local.timvisee.com:8080/90.37dd12f0.js:12
    ar http://local.timvisee.com:8080/90.37dd12f0.js:12
    wrapNative http://local.timvisee.com:8080/90.37dd12f0.js:12
    liner http://local.timvisee.com:8080/90.37dd12f0.js:12
    liner http://local.timvisee.com:8080/90.37dd12f0.js:12
    ar http://local.timvisee.com:8080/90.37dd12f0.js:12
    importKey http://local.timvisee.com:8080/90.37dd12f0.js:12
    Keychain http://local.timvisee.com:8080/app.6e75a70b.js:21463
    FileSender http://local.timvisee.com:8080/app.6e75a70b.js:18998
    default http://local.timvisee.com:8080/app.6e75a70b.js:10768
    _emit http://local.timvisee.com:8080/app.6e75a70b.js:119501
    emit http://local.timvisee.com:8080/app.6e75a70b.js:119393
    upload http://local.timvisee.com:8080/app.6e75a70b.js:59883

I'm testing locally with npm install && npm start on an HTTP domain. Do you use a different testing environment?

I'm sorry I can't dive into this further myself, I'm quite limited on time these days.

@AaronDewes
Copy link
Author

I'm just doing npm install && npm start, but on localhost. A polyfill is only needed for HTTP domains that are not localhost. I will try with another domain later.

@timvisee
Copy link
Owner

timvisee commented Sep 4, 2022

I've reverted the changes from #101, on which this PR builds further.

Once we get this PR properly implemented, I'm very happy to put it all back in. The conflicts currently showing are due to the reverted commits.

Please see #101 (comment).

Reverting commits: c624766...4ceac20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants