Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include pgai extension #462

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Include pgai extension #462

merged 1 commit into from
Jun 3, 2024

Conversation

jgpruitt
Copy link
Contributor

No description provided.

@jgpruitt jgpruitt requested a review from graveland May 23, 2024 20:37
@jgpruitt jgpruitt self-assigned this May 23, 2024
graveland
graveland approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@graveland graveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple trivial comments, but otherwise it looks good to me :)

One other comment: you should add a check in cicd/shared.sh, probably in the check_others function to validate that pgai was actually installed when it was requested.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@jgpruitt jgpruitt force-pushed the jgpruitt/pgai branch 2 times, most recently from 98c656b to 32107f8 Compare June 3, 2024 16:36
@jgpruitt jgpruitt marked this pull request as ready for review June 3, 2024 16:36
graveland
graveland approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@graveland graveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requirements.txt is a great improvement!

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@jgpruitt jgpruitt merged commit e722ae5 into master Jun 3, 2024
4 checks passed
@jgpruitt jgpruitt deleted the jgpruitt/pgai branch June 3, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graveland graveland graveland approved these changes

Assignees

@jgpruitt jgpruitt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jgpruitt @graveland