refactor!: move UDP worker to separate file #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkindahl
force-pushed
the
refactor-udp
branch
3 times, most recently
from
fcbbe3a
to
6312726
Compare
mkindahl
changed the title
In preparation to support multiple different protocols we move the UDP-specific pieces of code to a separate module and keep generic worker code in the worker module. We also rename some functions to reflect that we will have different protocols. BREAKING CHANGE: `worker_launch` is renamed to `launch_udp_worker` and `send_packet` is renamed to `send_udp_packet`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation to support multiple different protocols we move the UDP-specific
pieces of code to a separate module and keep generic worker code in the worker
module. We also rename some functions to reflect that we will have different
protocols.
BREAKING CHANGE:
worker_launchis renamed tolaunch_udp_workerandsend_packetis renamed tosend_udp_packet.