Add Imperial / Metric options to dashboards #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendavidson
changed the title
bendavidson
changed the title
|
Just want to let you know that I did not forget this MR, I am just super busy right now. Sorry |
|
No rush - I hadn't realised that the later commits would get included TBH
(we use BitBucket rather than GitHub here)!
…On Wed, 14 Sept 2022 at 13:43, Till Steinbach ***@***.***> wrote:
Just want to let you know that I did not forget this MR, I am just super
busy right now. Sorry
—
Reply to this email directly, view it on GitHub
<#327 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPATD5UU2AXAHXM6JCG6FDV6HB6PANCNFSM6AAAAAAQIYATOU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
If I saw it right, the function is only created in the migration script. For new users the function would also needed to be created (e.g. when the table is being created). |
|
Sorry, took me a while to work out how alchemy actually works - latest commit will create the DB function for new databases |
|
If I take this fork, will I lose all the data that I have already collected? Or does this version work with data stored in metric, and convert it to imperial for display only? |
|
No, this only affects the display of the data in Grafana, not the data
itself.
It does touch the database to add the conversion function, but it doesn't
change the data.
At the moment, only some dashboards have the conversion on them, but now I
have the 3.2 software I'll look to change the others which are now useful.
…On Thu, 19 Oct 2023 at 06:19, Will Scott ***@***.***> wrote:
If I take this fork, will I lose all the data that I have already
collected? Or does this version work with data stored in metric, and
convert it to imperial for display only?
—
Reply to this email directly, view it on GitHub
<#327 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPATD2BAARMPTDABNQHDGLYACZ7TAVCNFSM6AAAAAAQIYATOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRZHE4TAOJXG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.