Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binned guides discard out-of-bound breaks #5873

Merged
merged 4 commits into from May 20, 2024

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #5870.

Briefly, it includes a step where out-of-bounds breaks are discarded during the parsing of binned breaks.

Reprex from issue:

devtools::load_all("~/packages/ggplot2")
#> ℹ Loading ggplot2

ggplot(mpg, aes(displ, hwy, colour = hwy)) +
  geom_point() +
  guides(colour = guide_coloursteps(show.limits = T))

Created on 2024-05-01 with reprex v2.1.0

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 3b83eea into tidyverse:main May 20, 2024
11 checks passed
@teunbrand teunbrand deleted the bins_discard_oob branch May 20, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

guide_coloursteps(show.limits = T) produces strange lower limit
2 participants