Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geom_rect() can derive corners from x/width or y/height #5862

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

geom_rect() can derive corners from x/width or y/height #5862

wants to merge 17 commits into from

Commits on Apr 24, 2024

  1. required aesthetics to non-missing aes

    @teunbrand
    teunbrand committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    6dc3ba8 View commit details
    Browse the repository at this point in the history

  2. <GeomBar> doesn't inherit optional_aes

    @teunbrand
    teunbrand committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    65030f5 View commit details
    Browse the repository at this point in the history

  3. fill missing aes

    @teunbrand
    teunbrand committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    71923cc View commit details
    Browse the repository at this point in the history

  4. throw error when unresolveable

    @teunbrand
    teunbrand committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    93b45ad View commit details
    Browse the repository at this point in the history

  5. protect against partial matching

    @teunbrand
    teunbrand committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    99293fd View commit details
    Browse the repository at this point in the history

  6. add tests

    @teunbrand
    teunbrand committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    e992f51 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into flexible_rects

    @teunbrand
    teunbrand committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    68ce1fc View commit details
    Browse the repository at this point in the history

  8. add news bullet

    @teunbrand
    teunbrand committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    b083634 View commit details
    Browse the repository at this point in the history

  9. adjust docs

    @teunbrand
    teunbrand committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    984749c View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. fallback for corners wired through params

    @teunbrand
    teunbrand committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    41c6090 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Merge branch 'main' into flexible_rects

    @teunbrand
    teunbrand committed May 21, 2024
    Configuration menu
    Copy the full SHA
    83557d7 View commit details
    Browse the repository at this point in the history

  2. Revert "<GeomBar> doesn't inherit optional_aes" 

    This reverts commit 65030f5.
    @teunbrand
    teunbrand committed May 21, 2024
    Configuration menu
    Copy the full SHA
    0581b23 View commit details
    Browse the repository at this point in the history

  3. adapt check_required_aesthetics() to deal with multiple or-logic

    @teunbrand
    teunbrand committed May 21, 2024
    Configuration menu
    Copy the full SHA
    9395341 View commit details
    Browse the repository at this point in the history

  4. undo aesthetic field voodoo

    @teunbrand
    teunbrand committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f991ec5 View commit details
    Browse the repository at this point in the history

  5. fill data from params more reliably

    @teunbrand
    teunbrand committed May 21, 2024
    Configuration menu
    Copy the full SHA
    b990a2b View commit details
    Browse the repository at this point in the history

  6. throw error from resolve_rect()

    @teunbrand
    teunbrand committed May 21, 2024
    Configuration menu
    Copy the full SHA
    5d01396 View commit details
    Browse the repository at this point in the history

  7. document

    @teunbrand
    teunbrand committed May 21, 2024
    Configuration menu
    Copy the full SHA
    b79e68e View commit details
    Browse the repository at this point in the history