support optional annotated field with default value #862
+54
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is not possible to specify a
SQLModel
with anOptional
complex type, such as aDecimal
, as follows:Doing so results in the following error (see #67, #312) in
get_sqlalchemy_type
:TypeError: issubclass() arg 1 must be a class
This PR attempts to fix this issue by adding a check in
get_sqlalchemy_type
for whether the type of theField
is atyping_extensions.AnnotatedAlias
. If it is, instead of using the class of theAnnotatedAlias
for the following comparisons (which results in the above error), it usesAnnotatedAlias.__origin__
. Similarly, it infers the metadata fromAnnotatedAlias.__metadata__
instead of theAnnotatedAlias
itself.In my testing, this approach seems to work well. I also added a simple test here that checks whether restrictions on an optional annotated field are enforced on the database side. It could probably be improved or extended.