Bybit: Fix WS ticker processing #1538
Open
+350
−433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1538 +/- ##
==========================================
- Coverage 37.76% 35.86% -1.91%
==========================================
Files 409 409
Lines 147697 177282 +29585
==========================================
+ Hits 55780 63577 +7797
- Misses 84055 105864 +21809
+ Partials 7862 7841 -21
|
gloriousCode
requested changes
May 13, 2024
gloriousCode
requested changes
May 24, 2024
exchanges/bybit/bybit_test.go
Outdated
| assert.Equal(t, 11.00, v.Ask, "Ask should be correct") | ||
| assert.Equal(t, 5.10, v.AskSize, "AskSize should be correct") | ||
| assert.Equal(t, "BTC-USD-220930-28000-P", v.Pair.String(), "Pair should be correct") | ||
| assert.EqualValues(t, 233366401000, v.LastUpdated.UnixMilli(), "LastUpdated should be correct") |
There was a problem hiding this comment.
looks like you'll need to wrap with int64(...)
There was a problem hiding this comment.
Yep. That's EqualValues out the window for most use cases then 🪟
Fixed 2639b11
Merged
3 tasks
gbjk
force-pushed
the
bugfix/bybit_spot_ticker
branch
from
2639b11
to
64977cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
How has this been tested